feat(lvmsr): support vdi_revert on lvm - #128
Open
klmp200 wants to merge 1 commit into
Open
Conversation
klmp200
force-pushed
the
vdi_revert_lvm
branch
2 times, most recently
from
March 26, 2026 09:12
3e76b0c to
7706981
Compare
klmp200
force-pushed
the
vdi_revert_lvm
branch
3 times, most recently
from
April 20, 2026 08:46
4869f58 to
5a233c6
Compare
klmp200
force-pushed
the
vdi_revert_lvm
branch
5 times, most recently
from
April 24, 2026 15:03
278e57e to
32b6861
Compare
klmp200
force-pushed
the
vdi_revert_lvm
branch
4 times, most recently
from
May 22, 2026 12:38
4da951e to
70bb545
Compare
klmp200
force-pushed
the
vdi_revert_lvm
branch
2 times, most recently
from
June 11, 2026 15:17
127b385 to
6f7e5b3
Compare
klmp200
marked this pull request as ready for review
June 11, 2026 15:19
This was referenced Jun 11, 2026
klmp200
marked this pull request as draft
July 3, 2026 14:42
klmp200
marked this pull request as ready for review
July 10, 2026 16:17
Millefeuille42
requested changes
Jul 15, 2026
klmp200
commented
Jul 15, 2026
Millefeuille42
approved these changes
Jul 16, 2026
Lankou66
reviewed
Jul 16, 2026
| inserted.cowutil.setHidden(inserted.path, False) | ||
| inserted_ref = inserted._db_introduce() | ||
|
|
||
| util.fistpoint.activate("LVM_revert_create_src", self.sr.uuid) |
Lankou66
reviewed
Jul 16, 2026
| dest_ref = dest.session.xenapi.VDI.get_by_uuid(dest.uuid) | ||
| dest.sm_config = dest.session.xenapi.VDI.get_sm_config(dest_ref) | ||
|
|
||
| with dest.activated(False): |
There was a problem hiding this comment.
good practice to use context manager here
we have to use it more !
Lankou66
approved these changes
Jul 16, 2026
Lankou66
left a comment
Lankou66
left a comment
There was a problem hiding this comment.
LGTM
Good PR regarding the complexity of lvmsr code
GG
klmp200
force-pushed
the
vdi_revert_lvm
branch
from
August 24, 2026 08:25
f071ad1 to
84d0afa
Compare
* Support `vdi_revert` * Add journals for rollback in case of failure * Rewrite lvm journal creation with security feature against writing too much inside allocated space * Read more in lvm journal * Support CBT on vdi revert Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
klmp200
force-pushed
the
vdi_revert_lvm
branch
from
August 27, 2026 09:02
84d0afa to
da82fa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vdi_revertvdi_revertIntegration tests PR: xcp-ng/xcp-ng-tests#631
Stacked PR review
vdi_reverton lvm #128 <- Current